-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add internal mass to ground zone simulations #195
Add internal mass to ground zone simulations #195
Conversation
add InternalMass to ground zone creation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the .idea folder from this PR (this can be done by reverting the most recent commit).
Otherwise code-wise the changes look good. Will test these changes myself when I have a fresh install of pollination.
remove data folder saved from PyCharm
@Tom-Kingstone to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and can confirm that the changes do not break simulation models, though I can't comment on how valid the simulation results are. Await approving review from @tg359 before merge
@Tom-Kingstone to confirm, the following actions are now queued:
|
@Tom-Kingstone to confirm, the following actions are now queued:
There are 18 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved on the basis that the process hasn't broken and that inclusion of internal mass would only increase the accuracy of the simulation.
In the next testing sprint the unit tests downstream of this code will need to be updated (https://github.com/BHoM/LadybugTools_Toolkit/tree/develop/LadybugTools_Engine/Python/tests/test_external_comfort) to ensure that they too pass, as values will change from what the tests were written against, so those tests will likely fail until update are made.
@BHoMBot check ready-to-merge |
@Tom-Kingstone to confirm, the following actions are now queued:
|
Tom and I have reviewed unit tests, and no tests appear to be affected by these changes (either directly or downstream). This means that all unit tests are still passing, but also that there is probably a gap in the unit tests! I will add an issue to provide an additional test. |
Add InternalMass to ground zone creation part that feeds into SimulationResult process to get surface temperatures to replicate more accurate ground conditions.