Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed heatplot method not returning base64 encoded image #175

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

Tom-Kingstone
Copy link
Contributor

@Tom-Kingstone Tom-Kingstone commented Mar 7, 2024

NOTE: Depends on

Issues addressed by this PR

Closes #174

save_path variable now includes a check for empty string including None

Test files

LBT_Plots.zip
change the save directory (preset as C:/github/0_temp/temp.png) to an empty string or remove the panel entirely, and run the HeatPlotCommand

Changelog

Additional comments

@Tom-Kingstone Tom-Kingstone self-assigned this Mar 7, 2024
@Tom-Kingstone Tom-Kingstone added the type:bug Error or unexpected behaviour label Mar 7, 2024
@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check compliance

Copy link

bhombot-ci bot commented Mar 7, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@Tom-Kingstone Tom-Kingstone requested a review from albinber March 7, 2024 08:53
@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check versioning

Copy link

bhombot-ci bot commented Mar 7, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check versioning

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check required

Copy link

bhombot-ci bot commented Mar 7, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposed change works well.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Mar 12, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check unit-tests

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Mar 12, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check ready-to-merge

@jamesramsden-bh jamesramsden-bh merged commit 2ad6e16 into develop Mar 12, 2024
13 checks passed
@jamesramsden-bh jamesramsden-bh deleted the LadybugTools_Toolkit-#174-FixHeatPlot branch March 12, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Heatmap plot method does not return base64 encoded image
2 participants