Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implemented GetMaterial and GetTypology methods #141

Conversation

tg359
Copy link
Contributor

@tg359 tg359 commented Nov 15, 2023

Issues addressed by this PR

Closes #139

Following changes to how objects were being constructed, these methods were removed as they were becoming very slow. Now those changes have been optimised they can be re-implemented.

Test files

Just use the GetMaterial and GetTypology methods.

Changelog

Additional comments

@tg359 tg359 added severity:low Doesn't stop/slow current workflow size:S Measured in minutes priority:low Resources should be targeted to other issues first labels Nov 15, 2023
@tg359 tg359 requested a review from Tom-Kingstone November 15, 2023 10:12
@tg359 tg359 self-assigned this Nov 15, 2023
@Tom-Kingstone
Copy link
Contributor

@BHoMBot check versioning

Copy link

bhombot-ci bot commented Nov 15, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check versioning

There are 3 requests in the queue ahead of you.

@tg359
Copy link
Contributor Author

tg359 commented Nov 15, 2023

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Nov 15, 2023

@tg359 to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@tg359
Copy link
Contributor Author

tg359 commented Nov 15, 2023

@BHoMBot check required

Copy link

bhombot-ci bot commented Nov 15, 2023

@tg359 to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link

bhombot-ci bot commented Nov 15, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Nov 15, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Nov 15, 2023

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code came back, happy with it for now, thanks @tg359

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Nov 15, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

Copy link

bhombot-ci bot commented Nov 15, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd added the type:feature New capability or enhancement label Nov 15, 2023
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Nov 15, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Nov 15, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit a12cd35 into develop Nov 15, 2023
13 checks passed
@FraserGreenroyd FraserGreenroyd deleted the LadybugTools_Toolkit-#139-ReimplementPredefinedMaterialsAndTypologies branch November 15, 2023 17:32
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:low Resources should be targeted to other issues first severity:low Doesn't stop/slow current workflow size:S Measured in minutes type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reimplement loading of predefined Materials and Typology objects
3 participants