-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-implemented GetMaterial and GetTypology methods #141
Re-implemented GetMaterial and GetTypology methods #141
Conversation
@BHoMBot check versioning |
@Tom-Kingstone to confirm, the following actions are now queued:
There are 3 requests in the queue ahead of you. |
@BHoMBot check compliance |
@tg359 to confirm, the following actions are now queued:
|
@BHoMBot check required |
@tg359 to confirm, the following actions are now queued:
|
The check |
The check |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code came back, happy with it for now, thanks @tg359
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
Issues addressed by this PR
Closes #139
Following changes to how objects were being constructed, these methods were removed as they were becoming very slow. Now those changes have been optimised they can be re-implemented.
Test files
Just use the GetMaterial and GetTypology methods.
Changelog
Additional comments