-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed paths from C:/ProgramData to generic ProgramData folder #138
Changed paths from C:/ProgramData to generic ProgramData folder #138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have an issue with the C# changes, but the Python ones need to be converted to Path objects for any downstream operations (as currently they've been changed to strings instead of their original Path-type objects).
LadybugTools_Engine/Python/src/ladybugtools_toolkit/bhom/__init__.py
Outdated
Show resolved
Hide resolved
LadybugTools_Engine/Python/src/ladybugtools_toolkit/bhom/__init__.py
Outdated
Show resolved
Hide resolved
LadybugTools_Engine/Python/src/ladybugtools_toolkit/bhom/__init__.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Tristan Gerrish <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me 👍
@BHoMBot check compliance |
@Tom-Kingstone to confirm, the following actions are now queued:
|
@BHoMBot check required |
@Tom-Kingstone to confirm, the following actions are now queued:
There are 7 requests in the queue ahead of you. |
The check |
The check |
@Tom-Kingstone to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code reviewed and is appropriate for the issue raised, happy to deploy for testing via alphas.
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
NOTE: Depends on
Issues addressed by this PR
Closes #137
Used os.path to get the common
ProgramData
folder rather than specifically referring toC:/ProgramData
in python, and usedSystem.Environment.GetFolderPath()
to get the path to Program Files when installing python and checking pollination installTest files
Changelog
Additional comments