Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed paths from C:/ProgramData to generic ProgramData folder #138

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

Tom-Kingstone
Copy link
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #137

Used os.path to get the common ProgramData folder rather than specifically referring to C:/ProgramData in python, and used System.Environment.GetFolderPath() to get the path to Program Files when installing python and checking pollination install

Test files

Changelog

Additional comments

@Tom-Kingstone Tom-Kingstone added the type:compliance Non-conforming to code guidelines label Nov 15, 2023
@Tom-Kingstone Tom-Kingstone self-assigned this Nov 15, 2023
Copy link
Contributor

@tg359 tg359 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have an issue with the C# changes, but the Python ones need to be converted to Path objects for any downstream operations (as currently they've been changed to strings instead of their original Path-type objects).

@Tom-Kingstone Tom-Kingstone requested a review from tg359 November 15, 2023 09:38
Copy link
Contributor

@tg359 tg359 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me 👍

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Nov 15, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check required

Copy link

bhombot-ci bot commented Nov 15, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 7 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Nov 15, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Nov 15, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check unit-tests
@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Nov 15, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check unit-tests
  • check ready-to-merge

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code reviewed and is appropriate for the issue raised, happy to deploy for testing via alphas.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Nov 15, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit e5b3083 into develop Nov 15, 2023
13 checks passed
@FraserGreenroyd FraserGreenroyd deleted the LadybugTools_Toolkit-#137-ProgramData branch November 15, 2023 15:26
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change references to C:/ProgramData
3 participants