Removed auto-constructors for finicky objects

[tg359]

NOTE: Depends on

Issues addressed by this PR

Closes #131

[NoAutoConstructor] added to objects where they are either created via a process, or have some validation required in order to be suitable for use in downstream processes.

Test files

Changelog

Additional comments

[Tom-Kingstone]

Some minor changes needed

[FraserGreenroyd]

Project compliance will fail so let's get the bot to fix that after Typology.

@BHoMBot check project-compliance

[Tom-Kingstone]

@BHoMBot check project-compliance

[bhombot-ci]

@Tom-Kingstone to confirm, the following actions are now queued:

• check project-compliance

There are 11 requests in the queue ahead of you.

[bhombot-ci]

@FraserGreenroyd fix requested for project compliance.

The errors with the CSProject (.csproj) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix project file ref. 18659371395

[FraserGreenroyd]

@BHoMBot fix project file ref. 18659371395

[bhombot-ci]

@FraserGreenroyd I have queued up your request to fix the csproj file(s). There are 2 requests in the queue ahead of you.

[bhombot-ci]

@FraserGreenroyd I am now going to fix the project compliance in accordance with the annotations previously made.

[bhombot-ci]

@FraserGreenroyd to confirm I have now resolved the project compliance issues and pushed a commit to this Pull Request.

[FraserGreenroyd]

@BHoMBot check compliance

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

There are 2 requests in the queue ahead of you.

[Tom-Kingstone]

@BHoMBot check compliance
@BHoMBot check required

[bhombot-ci]

@Tom-Kingstone to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance
• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

There are 1 requests in the queue ahead of you.

[bhombot-ci]

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[FraserGreenroyd]

All good on code review with comments resolved, thanks @Tom-Kingstone for picking up the additional NoAutoConstructor discussed with @tg359 on Teams.

Happy to deploy for further testing.

[Tom-Kingstone]

approved as @FraserGreenroyd will set out

[FraserGreenroyd]

@BHoMBot check compliance
@BHoMBot check required

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance
• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

[FraserGreenroyd]

Reapproving based on this comment following a rebase to resolve conflicts.

[bhombot-ci]

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[FraserGreenroyd]

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: installer, unit-tests, ready-to-merge

[bhombot-ci]

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.