Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging file handler fix #134

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Conversation

tg359
Copy link
Contributor

@tg359 tg359 commented Nov 13, 2023

NOTE: Depends on

Issues addressed by this PR

Closes #132

Logging should no longer get confused and try to rewrite to a blocked file. Additionally, the method for tagging the logs now removes the config.ini to save on time spent opening/closing files with each call.

Also updates a few of the Compute methods which call to Python to convert files so that they use the new method of running an external *.py file instead of having the Python command strings within the C# methods - to save on headaches for people trying to debug (the *.py files can then be debugged outside of C# if necessary).

Test files

Changelog

Additional comments

@tg359 tg359 self-assigned this Nov 13, 2023
@tg359 tg359 added severity:low Doesn't stop/slow current workflow size:S Measured in minutes labels Nov 13, 2023
Copy link
Contributor

@Tom-Kingstone Tom-Kingstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one request for now :)

LadybugTools_Engine/Compute/HBJSONtoGEM.cs Show resolved Hide resolved
@tg359 tg359 requested a review from Tom-Kingstone November 13, 2023 13:02
@Tom-Kingstone Tom-Kingstone added size:L Measured in days and removed size:S Measured in minutes labels Nov 14, 2023
@Tom-Kingstone
Copy link
Contributor

@BHoMBot check core
@BHoMBot check compliance

Copy link

bhombot-ci bot commented Nov 14, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 11 requests in the queue ahead of you.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good on code review @tg359 happy with the tests running as usual. Have made a comment for a change in another PR for @Tom-Kingstone to pick up but otherwise, let's get this merged and out of the way 😄

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check required

Copy link

bhombot-ci bot commented Nov 14, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link

bhombot-ci bot commented Nov 14, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Nov 14, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Nov 14, 2023

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

@Tom-Kingstone Tom-Kingstone added the type:feature New capability or enhancement label Nov 14, 2023
@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests, ready-to-merge, installer

Copy link

bhombot-ci bot commented Nov 14, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit de50c9c into develop Nov 14, 2023
13 checks passed
@FraserGreenroyd FraserGreenroyd deleted the LBT_Tk-#132-LoggingFileHandlerFix branch November 14, 2023 10:45
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity:low Doesn't stop/slow current workflow size:L Measured in days type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update RotatingFileHandler in Python code to stop permissions error when calling it LOTS
3 participants