-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging file handler fix #134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one request for now :)
@Tom-Kingstone to confirm, the following actions are now queued:
There are 11 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good on code review @tg359 happy with the tests running as usual. Have made a comment for a change in another PR for @Tom-Kingstone to pick up but otherwise, let's get this merged and out of the way 😄
@BHoMBot check required |
@FraserGreenroyd to confirm, the following actions are now queued:
|
The check |
The check |
The check |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests, ready-to-merge, installer |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
NOTE: Depends on
Issues addressed by this PR
Closes #132
Logging should no longer get confused and try to rewrite to a blocked file. Additionally, the method for tagging the logs now removes the config.ini to save on time spent opening/closing files with each call.
Also updates a few of the Compute methods which call to Python to convert files so that they use the new method of running an external *.py file instead of having the Python command strings within the C# methods - to save on headaches for people trying to debug (the *.py files can then be debugged outside of C# if necessary).
Test files
Changelog
Additional comments