Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed test failure due to mismatch in object properties #117

Merged

Conversation

tg359
Copy link
Contributor

@tg359 tg359 commented Sep 13, 2023

… to avoid failure in passing data between languages

Issues addressed by this PR

Failure in testing of code passed between BHoM/C# and Python where objects hadn't been fully updated to match new schema. Minor fix to ensure that properties can be populated to stop failure in this process.

Test files

LBT_Tk test script should now function fully, so I'd suggest using that to test as otherwise it returns a failure.

Changelog

Additional comments

… to avoid failure in passing data between languages
@tg359 tg359 added severity:medium Slows progress, but workaround is possible size:S Measured in minutes type:bug Error or unexpected behaviour labels Sep 13, 2023
@tg359 tg359 self-assigned this Sep 13, 2023
@albinber
Copy link

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 13, 2023

@albinber to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check required
@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 13, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer
  • check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 13, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 13, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 13, 2023

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed through with @tg359

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 13, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 1 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit 803ecf5 into develop Sep 13, 2023
12 of 13 checks passed
@FraserGreenroyd FraserGreenroyd deleted the LadybugTools_Toolkit-#XX-6.3TestingSprintBugFixes branch September 13, 2023 15:19
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity:medium Slows progress, but workaround is possible size:S Measured in minutes type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants