Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor serialisation of python inputs/outputs #136

Closed
Tom-Kingstone opened this issue Nov 14, 2023 · 1 comment · Fixed by #142
Closed

Refactor serialisation of python inputs/outputs #136

Tom-Kingstone opened this issue Nov 14, 2023 · 1 comment · Fixed by #142
Assignees
@Tom-Kingstone
Labels
type:feature New capability or enhancement

Comments

@Tom-Kingstone
Copy link
Contributor

Description:

Move serialisation into an adapter so that their methods are hidden from the user.

  • Create methods that convert BHoM objects to python readable json files.
  • Read methods for converting from python json file output to BHoM objects.
@Tom-Kingstone Tom-Kingstone added the type:feature New capability or enhancement label Nov 14, 2023
@Tom-Kingstone Tom-Kingstone self-assigned this Nov 14, 2023
@Tom-Kingstone Tom-Kingstone mentioned this issue Nov 14, 2023
Open
Tom-Kingstone added a commit that referenced this issue Nov 16, 2023
@Tom-Kingstone
Merge branch 'LadybugTools_Toolkit-#136-SerialisationRefactor' of htt…
ceeeae0 
…ps://github.com/BHoM/LadybugTools_Toolkit into LadybugTools_Toolkit-#136-SerialisationRefactor
@tg359
Copy link
Contributor

tg359 commented Nov 16, 2023

@Tom-Kingstone here are a bunch of pre-serialised files for testing of this. Many object conversions not in there yet, but I've also included some geometries in here which would mean that we could interop with other LB/HB workflows.

SerialisedLBHBobjects.zip

@Tom-Kingstone Tom-Kingstone mentioned this issue Nov 22, 2023
Merged
Tom-Kingstone added a commit that referenced this issue Nov 22, 2023
@Tom-Kingstone
Merge branch 'LadybugTools_Toolkit-#136-SerialisationRefactor' of htt…
eb18f8f 
…ps://github.com/BHoM/LadybugTools_Toolkit into LadybugTools_Toolkit-#136-SerialisationRefactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tom-Kingstone Tom-Kingstone

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adapter methods: Serialisation to and from ladybug objects BHoM/LadybugTools_Toolkit
2 participants
@tg359 @Tom-Kingstone