Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency to MongoDB #2

Closed
wants to merge 1 commit into from

Conversation

adecler
Copy link
Member

@adecler adecler commented Nov 18, 2022

Issues addressed by this PR

Closes BHoM/BHoM_Engine#2948

Additional comments

This repo didn't actually need Mongo packages. I had to make quite a few changes just to get the code to compile. While there are still some compiling alerts that needs resolving, I kept the changes to a minimum to stay within the scope of the issue while having a code that compiles.

@adecler adecler added the type:external-api-changes Imposed changes, including from dependency across other BHoM repos label Nov 18, 2022
@adecler adecler self-assigned this Nov 18, 2022
@adecler
Copy link
Member Author

adecler commented Nov 18, 2022

@BHoMBot check project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 18, 2022

@adecler to confirm, the following actions are now queued:

  • check project-compliance

There are 22 requests in the queue ahead of you.

@alelom
Copy link
Member

alelom commented Nov 18, 2022

Thanks @adecler . This toolkit is actually being reworked by our external collaborator @EnricoAntolini from Karamba -- reason why many things needed to be changed just to compile is that the main was just an initial quick draft, and the work is now being done on a separate branch. If you agree, I can remember the changes you've done here and work with @EnricoAntolini in order to replicate them on his branch before we merge it -- I'd say it's a safer option to avoid conflicts.

@adecler
Copy link
Member Author

adecler commented Nov 18, 2022

Thanks @alelom , as long as this repo is not part of any installer, I am happy for it to be dealt with separately.
Just important notice for any one compiling this repo that there will be quite a few serialisations issues (including loading BHoM components as they use serialisation) if different toolkits use different versions of Mongo.

@alelom alelom closed this Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:external-api-changes Imposed changes, including from dependency across other BHoM repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure the same version of MongoDB is used across all repos
2 participants