Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing shade push #203

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Fixing shade push #203

merged 2 commits into from
Nov 29, 2022

Conversation

kprusicka
Copy link
Contributor

Issues addressed by this PR

Closes #202

@kprusicka kprusicka added the type:bug Error or unexpected behaviour label Nov 29, 2022
@kprusicka kprusicka self-assigned this Nov 29, 2022
@kprusicka
Copy link
Contributor Author

@BHoMBot Check required

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 29, 2022

@kprusicka to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@kprusicka
Copy link
Contributor Author

kprusicka commented Nov 29, 2022

Thank you @BHoMBot

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 29, 2022

@kprusicka you're very welcome! 😄

@BHoM BHoM deleted a comment from bhombot-ci bot Nov 29, 2022
@bhombot-ci
Copy link

bhombot-ci bot commented Nov 29, 2022

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 29, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check null-handling

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 29, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes address the issue, tested through with @kprusicka and null handling added suitably.
Merging for deployment via alphas.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 29, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 15 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 29, 2022

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 29, 2022

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 29, 2022

The check null-handling has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 29, 2022

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 29, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

There are 17 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 29, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit d024a0e into main Nov 29, 2022
@FraserGreenroyd FraserGreenroyd deleted the IES_Toolkit-#202-ShadesType branch November 29, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shade spaces not registered as the correct type in IES
2 participants