Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compliance of CanvasID file #666

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

FraserGreenroyd
Copy link
Contributor

Issues addressed by this PR

Fixes #665

Test files

Changelog

Additional comments

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 19, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 19, 2022

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 19, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance

There are 5 requests in the queue ahead of you.

Copy link

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, checked for wording and typos, all fine.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 20, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 31 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 20, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 32 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 20, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 33 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 20, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 34 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 20, 2022

The check ready-to-merge has already been run previously and recorded as a successful check. This check has not been run again at this time.

2 similar comments
@bhombot-ci
Copy link

bhombot-ci bot commented Oct 20, 2022

The check ready-to-merge has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 20, 2022

The check ready-to-merge has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd FraserGreenroyd merged commit b919449 into main Oct 20, 2022
@FraserGreenroyd FraserGreenroyd deleted the Grasshopper_UI-#665-Compliance branch October 20, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix compliance of CanvasID
2 participants