Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prototyping reflection of external libraries #393

Merged
merged 8 commits into from
Aug 28, 2019
Merged

Prototyping reflection of external libraries #393

merged 8 commits into from
Aug 28, 2019

Conversation

epignatelli
Copy link
Member

@epignatelli epignatelli commented Aug 8, 2019 •
edited
Loading

NOTE: Depends on BHoM/BHoM_Engine#1132

NOTE: Depends on BHoM/BHoM_UI#120

To test the prototype, switch to the correspondent (identically named) branches in the BHoM_UI and the BHoM_Engine

Issues addressed by this PR

This mainly supports the changes in the dependent pull requests

Test files

The test comes with the PR on the Numpy_Toolkit: BHoM/Numpy_Toolkit#2

Changelog

  • Add the new ExternalComponent component to reflect external libraries

Eduardo Pignatelli added 2 commits August 1, 2019 15:09
@epignatelli epignatelli added the type:feature New capability or enhancement label Aug 8, 2019
@epignatelli epignatelli added this to the BHoM 2.4 β MVP milestone Aug 8, 2019
@epignatelli epignatelli self-assigned this Aug 8, 2019
@al-fisher al-fisher added the status:WIP PR in progress and still in draft, not ready for formal review label Aug 12, 2019
@epignatelli epignatelli removed the status:WIP PR in progress and still in draft, not ready for formal review label Aug 16, 2019
@epignatelli epignatelli marked this pull request as ready for review August 16, 2019 14:31
@epignatelli epignatelli requested review from tg359 and removed request for tg359 August 16, 2019 14:32
@epignatelli
Copy link
Member Author

epignatelli commented Aug 16, 2019 •
edited
Loading

@FraserGreenroyd any idea why the CI is failing?

Ah, edit:
I'll take it back, I know why.

good spot @appveyor

@epignatelli epignatelli removed this from the BHoM 2.4 β MVP milestone Aug 19, 2019
@epignatelli epignatelli changed the title [WIP] Grasshopper_Toolkit: Prototyping reflection of external libraries Grasshopper_Toolkit: Prototyping reflection of external libraries Aug 19, 2019
adecler
adecler approved these changes Aug 28, 2019
View reviewed changes
Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me and framework compliant.

@adecler adecler merged commit 7296055 into master Aug 28, 2019
@adecler adecler deleted the BHoM_Engine-#1131-ReflectingExternalLibraries branch August 28, 2019 02:05
@epignatelli epignatelli mentioned this pull request Aug 30, 2019
Closed
@FraserGreenroyd FraserGreenroyd changed the title Grasshopper_Toolkit: Prototyping reflection of external libraries Prototyping reflection of external libraries Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adecler adecler adecler approved these changes

@al-fisher al-fisher Awaiting requested review from al-fisher

Assignees

@epignatelli epignatelli

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@epignatelli @adecler @al-fisher