Prototyping reflection of external libraries #120
Conversation
epignatelli
changed the title
al-fisher
added
the
status:WIP
…sary handling of different cases
| @@ -238,11 +173,28 @@ public virtual void SetInputParams() | |||
| HasDefaultValue = x.HasDefaultValue, | |||
| DefaultValue = x.DefaultValue | |||
| }).ToList(); | |||
| if (Method is MethodInfo && !Method.IsStatic) | |||
There was a problem hiding this comment.
Inserting the instance as an input if the method is an instance method
| } | ||
| } | ||
|
|
||
| /*************************************/ | ||
|
|
||
| public virtual void SetDelegate() |
There was a problem hiding this comment.
The old CompileFunction now calls the ToFunc from the Reflection_Engine
| @@ -1,92 +0,0 @@ | |||
| /* | |||
There was a problem hiding this comment.
Migrated to the Reflection_Engine
| @@ -1,85 +0,0 @@ | |||
| /* | |||
There was a problem hiding this comment.
Migrated to the Data_Engine
| @@ -37,7 +37,7 @@ public static partial class Query | |||
|
|
|||
| public static IEnumerable<MethodBase> EngineItems() | |||
| { | |||
| return Engine.Reflection.Query.BHoMMethodList().Where(x => !x.IsNotImplemented() && !x.IsDeprecated()); | |||
| return Engine.Reflection.Query.BHoMMethodList().Where(x => x.IsExposed()); | |||
There was a problem hiding this comment.
Using the new centralised way to filter out methods we don't want to expose
epignatelli
removed
the
status:WIP
epignatelli
changed the title
adecler
changed the title
| { | ||
| m_CompiledFunc = Method.ToFunc(); | ||
| } | ||
|
|
||
| public virtual void SetOutputParams() |
There was a problem hiding this comment.
You forgot to put the separator comment here.
Although to be honest, I am not sure I see the need of this method as it is a one liner is is only called once
| /***************************************************/ | ||
| /**** Public Methods ****/ | ||
| /***************************************************/ | ||
| public override string Name { get; protected set; } = "ExternalCompute"; |
There was a problem hiding this comment.
I would prefer it to be name External instead of ExternalCompute.
I understand where you're going with this but not every linked method is going to correspond to a Compute format so I'd rather stick to External to avoid the parallel.
|
Thanks @adecler for the review! |
FraserGreenroyd
changed the title
NOTE: Depends on BHoM/BHoM_Engine#1132
To test the prototype, switch to the correspondent (identically named) branches in the Grasshopper_Toolkit and the BHoM_Engine
Issues addressed by this PR
This mainly supports BHoM/BHoM_Engine#1132
Closes #118 as a side effect
This pr add the
ExternalCallercomponent that contains all the methods from external libraries.As discussed with @adecler I tried to make it as BHoMmy as possible by modifying a little bit the
MethodCaller. This way the new component fits into the pattern of all the other Engine methods.On the other hand, this pr migrates a set of methods to the Reflection_Engine, since they are much more general.
As usual, I left some comments on the diff itself to clarify the modifications.
Test files
The test comes with the PR on the Numpy_Toolkit: BHoM/Numpy_Toolkit#2
Changelog
ExternalCallercomponent that can reflect any external assemblyCompileFunctionmethod to the Reflection_Engine asEngine.Reflection.Convert.ToFuncGetConstructedTypemethod to the Reflection_Engine asEngine.Reflection.Modify.MakeGenericEngine.UI.Create.MethodInfoto the Reflection_Engine asEngine.Reflection.Create.MethodInfoEngine.UI.Modify.GroupMethodsByNameto the Data_Engine asEngine.Data.Modify.GroupByNameand clarified it is a generic methodAdditional comments