Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to get GSA ready for altconfigs in installers. #268

Merged
merged 5 commits into from
Oct 14, 2022

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented Sep 29, 2022

Issues addressed by this PR

Get GSA ready for inclusion in installers

Link to installer: https://burohappold.sharepoint.com/:f:/s/BHoM/EvGchF7-ctJCvjYPf76uG2ABbViKvnThhddyo4-Y-_770g?e=jNZKA4

Rename GSA_10_1Adapter to GSA101Adapter to match what is done elsewhere
Rename GSA_8_7Adatper to GSA87Adapter to match what is done elsewhere
Add versioning to accommodate the above
Add versioning from GSAAdapter -> GSA87Adapter as GSAAdapter wont be part of installers as soon as altconfigs start building. The previous the Debug build behaves as the Debug87 build (same for release) so an upgrade to GSA87Adapter should give the same behaviour for old scripts. If a script should start targeting GSA10.1, a change of adapter is required, but this should be expected as it is a new target.

Test files

Running of installers produced by installer PRs and ensuring that GSA87Adapter and GSA101Adapters exists.
Opening old scripts with GSAAdapter present and make sure they are updated to GSA87ADapter and functions as before.
Opening old scripts with GSA_10_1Adapter making sure they are correctly versioned and functions.

Changelog

Additional comments

- GSAAdapter -> GSA87Adapter (GSA adapter will no longer be part of installers. It behaved as the GSA87ADapter did, so should be updated to match)
- GSA_8_7Adapter -> GSA87Adapter (removing the _. Never part of installers, but adding to allow for clean upgrade for scripts built by people building of branch)
- GSA_10_1Adapter -> GSA101Adapter (removing the _. Never part of installers, but adding to allow for clean upgrade for scripts built by people building of branch)
@IsakNaslundBh IsakNaslundBh added the type:feature New capability or enhancement label Sep 29, 2022
@IsakNaslundBh IsakNaslundBh self-assigned this Sep 29, 2022
@bhombot-ci
Copy link

bhombot-ci bot commented Sep 29, 2022

@IsakNaslundBh just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Installer

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check versioning

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check versioning
please

@FraserGreenroyd
Copy link
Contributor

FraserGreenroyd commented Sep 29, 2022

@BHoMBot pretty please can you check core for me?

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 29, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core

@IsakNaslundBh
Copy link
Contributor Author

IsakNaslundBh commented Sep 29, 2022

@BHoMBot pretty pretty please check versioning for me. That would be great thanks!

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 29, 2022

@IsakNaslundBh to confirm, the following actions are now queued:

  • check versioning

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 30, 2022

@IsakNaslundBh just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Installer

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 30, 2022

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 3, 2022

@IsakNaslundBh just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Installer

4 similar comments
@bhombot-ci
Copy link

bhombot-ci bot commented Oct 11, 2022

@IsakNaslundBh just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Installer

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 11, 2022

@IsakNaslundBh just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Installer

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 11, 2022

@IsakNaslundBh just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Installer

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 12, 2022

@IsakNaslundBh just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Installer

Copy link
Contributor

@johannaisak johannaisak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, all working as expected

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 14, 2022

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 14, 2022

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 14, 2022

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 14, 2022

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 14, 2022

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 14, 2022

@IsakNaslundBh to confirm, the following actions are now queued:

  • check ready-to-merge

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am satisfied from a DevOps perspective with the review performed by @johannaisak and BHoMBot for this PR, and the updates to the installer, so am happy for this to go in from my side.

@FraserGreenroyd FraserGreenroyd merged commit efb485d into main Oct 14, 2022
@FraserGreenroyd FraserGreenroyd deleted the BHoM_Installer-#165-AddAltConfigsForGsa branch October 14, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants