-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweaks to get GSA ready for altconfigs in installers. #268
Tweaks to get GSA ready for altconfigs in installers. #268
Conversation
- GSAAdapter -> GSA87Adapter (GSA adapter will no longer be part of installers. It behaved as the GSA87ADapter did, so should be updated to match) - GSA_8_7Adapter -> GSA87Adapter (removing the _. Never part of installers, but adding to allow for clean upgrade for scripts built by people building of branch) - GSA_10_1Adapter -> GSA101Adapter (removing the _. Never part of installers, but adding to allow for clean upgrade for scripts built by people building of branch)
@IsakNaslundBh just to let you know, I have provided a |
@BHoMBot pretty please can you check core for me? |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot pretty pretty please check versioning for me. That would be great thanks! |
@BHoMBot check versioning |
@IsakNaslundBh to confirm, the following actions are now queued:
|
@BHoMBot check compliance |
@IsakNaslundBh just to let you know, I have provided a |
@BHoMBot check compliance |
@IsakNaslundBh to confirm, the following actions are now queued:
|
@IsakNaslundBh just to let you know, I have provided a |
4 similar comments
@IsakNaslundBh just to let you know, I have provided a |
@IsakNaslundBh just to let you know, I have provided a |
@IsakNaslundBh just to let you know, I have provided a |
@IsakNaslundBh just to let you know, I have provided a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, all working as expected
@IsakNaslundBh to confirm, the following actions are now queued:
|
The check |
The check |
The check |
The check |
@BHoMBot check ready-to-merge |
@IsakNaslundBh to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am satisfied from a DevOps perspective with the review performed by @johannaisak and BHoMBot for this PR, and the updates to the installer, so am happy for this to go in from my side.
Issues addressed by this PR
Get GSA ready for inclusion in installers
Link to installer: https://burohappold.sharepoint.com/:f:/s/BHoM/EvGchF7-ctJCvjYPf76uG2ABbViKvnThhddyo4-Y-_770g?e=jNZKA4
Rename GSA_10_1Adapter to GSA101Adapter to match what is done elsewhere
Rename GSA_8_7Adatper to GSA87Adapter to match what is done elsewhere
Add versioning to accommodate the above
Add versioning from GSAAdapter -> GSA87Adapter as GSAAdapter wont be part of installers as soon as altconfigs start building. The previous the Debug build behaves as the Debug87 build (same for release) so an upgrade to GSA87Adapter should give the same behaviour for old scripts. If a script should start targeting GSA10.1, a change of adapter is required, but this should be expected as it is a new target.
Test files
Running of installers produced by installer PRs and ensuring that GSA87Adapter and GSA101Adapters exists.
Opening old scripts with GSAAdapter present and make sure they are updated to GSA87ADapter and functions as before.
Opening old scripts with GSA_10_1Adapter making sure they are correctly versioned and functions.
Changelog
Additional comments