-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for GSA 10.1 #244
Add support for GSA 10.1 #244
Conversation
aaf61e0
to
4232ddf
Compare
@BHoMBot check project-compliance |
@IsakNaslundBh to confirm, the following checks are now queued:
|
@BHoMBot check copyright-compliance |
@IsakNaslundBh to confirm, the following checks are now queued:
|
@BHoMBot check compliance |
@IsakNaslundBh to confirm, the following checks are now queued:
|
The check |
The check |
@BHoMBot check compliance |
@IsakNaslundBh to confirm, the following checks are now queued:
There are 12 requests in the queue ahead of you. |
@IsakNaslundBh to confirm, the following checks are now queued:
There are 8 requests in the queue ahead of you. |
Please be advised that the check with reference 4869978120 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 61 additional annotations waiting, made up of 61 errors and 0 warnings. |
3bfe179
to
a0922da
Compare
@BHoMBot check compliance |
@IsakNaslundBh to confirm, the following checks are now queued:
There are 663 requests in the queue ahead of you. |
Added ability to read damper property to support reading of nodes. Stiffness previously integrated as properties of the node in GSA 8.7. In GSA 10.1 stiffness is added via a separate 'damper' property.
c5d5f13
to
b0cb95b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have been using the PR over the last month without issues
Thanks @johannaisak . Will try to get this merged today then, and after that, see if we can get GSA10 support added to the installers. |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 47 requests in the queue ahead of you. |
The check |
The check |
The check |
@BHoMBot check ready-to-merge |
Will dispense/ask for dispensation on the project compliance, and raise as a separate PR. Issue for this raised #266 |
@BHoMBot please check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 19 requests in the queue ahead of you. |
To confirm I have discussed this with @IsakNaslundBh and am happy with this approach from a DevOps perspective, so will be ok with @IsakNaslundBh doing the dispensation on this PR. |
FAO: @FraserGreenroyd The check they wish to have dispensation on is project-compliance. If you are providing dispensation on this occasion, please reply with:
|
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 8595866469 |
@IsakNaslundBh I have now provided a passing check on reference |
Issues addressed by this PR
Closes #242
Updating GSA Toolkit to support GSA 10.1.
Test files
Test Files