Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GSA 10.1 #244

Merged
merged 31 commits into from
Sep 28, 2022

Conversation

annastigenberg
Copy link
Contributor

@annastigenberg annastigenberg commented Jun 8, 2021

Issues addressed by this PR

Closes #242

Updating GSA Toolkit to support GSA 10.1.

Test files

Test Files

@annastigenberg annastigenberg added the status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge label Jun 8, 2021
@annastigenberg annastigenberg self-assigned this Jun 8, 2021
@IsakNaslundBh IsakNaslundBh force-pushed the GSA_Toolkit-#242-Upgrade-To-Support-GSA-10.1 branch from aaf61e0 to 4232ddf Compare January 18, 2022 13:07
@IsakNaslundBh
Copy link
Contributor

@BHoMBot check project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 18, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • project-compliance

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 18, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • copyright-compliance

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 18, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 18, 2022

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 18, 2022

The check copyright-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 18, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

There are 12 requests in the queue ahead of you.

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check required
@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 19, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer
  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

There are 8 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 19, 2022

Please be advised that the check with reference 4869978120 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 61 additional annotations waiting, made up of 61 errors and 0 warnings.

@IsakNaslundBh IsakNaslundBh force-pushed the GSA_Toolkit-#242-Upgrade-To-Support-GSA-10.1 branch from 3bfe179 to a0922da Compare January 26, 2022 14:52
@IsakNaslundBh
Copy link
Contributor

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented May 18, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

There are 663 requests in the queue ahead of you.

@alelom alelom added the type:feature New capability or enhancement label Jun 15, 2022
@johannaisak
Copy link
Contributor

Think I've found a bug in fabric material pushing, it comes in as just one material even if I have two different ones in grasshopper. I've put a test script in the test script folder. It does not happen in 8.7.
image
image

@IsakNaslundBh IsakNaslundBh force-pushed the GSA_Toolkit-#242-Upgrade-To-Support-GSA-10.1 branch from c5d5f13 to b0cb95b Compare September 8, 2022 11:58
Copy link
Contributor

@johannaisak johannaisak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have been using the PR over the last month without issues

@IsakNaslundBh IsakNaslundBh removed the status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge label Sep 28, 2022
@IsakNaslundBh
Copy link
Contributor

Have been using the PR over the last month without issues

Thanks @johannaisak .

Will try to get this merged today then, and after that, see if we can get GSA10 support added to the installers.

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 28, 2022

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 47 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 28, 2022

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 28, 2022

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 28, 2022

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check ready-to-merge

@IsakNaslundBh
Copy link
Contributor

Will dispense/ask for dispensation on the project compliance, and raise as a separate PR. Issue for this raised #266

@FraserGreenroyd
Copy link
Contributor

@BHoMBot please check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 28, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 19 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

Will dispense/ask for dispensation on the project compliance, and raise as a separate PR. Issue for this raised #266

To confirm I have discussed this with @IsakNaslundBh and am happy with this approach from a DevOps perspective, so will be ok with @IsakNaslundBh doing the dispensation on this PR.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 28, 2022

FAO: @FraserGreenroyd
@IsakNaslundBh is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is project-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 8595866469

@IsakNaslundBh
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 8595866469

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 28, 2022

@IsakNaslundBh I have now provided a passing check on reference 8595866469 as requested.

@IsakNaslundBh IsakNaslundBh merged commit 5c040e6 into main Sep 28, 2022
@IsakNaslundBh IsakNaslundBh deleted the GSA_Toolkit-#242-Upgrade-To-Support-GSA-10.1 branch September 28, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for GSA 10.1
5 participants