Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix project file #167

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Fix project file #167

merged 1 commit into from
Jul 17, 2023

Conversation

FraserGreenroyd
Copy link
Contributor

Fixes #166

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Jul 17, 2023
@FraserGreenroyd FraserGreenroyd self-assigned this Jul 17, 2023
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 17, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 13 requests in the queue ahead of you.

travispotterBH
travispotterBH approved these changes Jul 17, 2023
View reviewed changes
Copy link

@travispotterBH travispotterBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Necessary for bot.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: core, installer, null-handling, ready-to-merge, serialisation, versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 17, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 17, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit c2d76ff into develop Jul 17, 2023
@FraserGreenroyd FraserGreenroyd deleted the File_Toolkit-#166-Project branch July 17, 2023 17:26
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
Merged
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travispotterBH travispotterBH travispotterBH approved these changes

@desaiwangBH desaiwangBH Awaiting requested review from desaiwangBH

Assignees

@FraserGreenroyd FraserGreenroyd

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BaseOutputPath is not valid
2 participants
@FraserGreenroyd @travispotterBH