-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File_Toolkit: Add unit tests #163
Conversation
@BHoMBot check unit-tests |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 35 requests in the queue ahead of you. |
@BHoMBot check copyright-compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 2 requests in the queue ahead of you. |
@FraserGreenroyd fix requested for copyright headers. The errors with the copyright headers on the CS ( I will apply the fixes to every case detailed on the checks tab. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. Each CS ( If you are happy for me to go ahead and perform this action, please reply with:
|
@BHoMBot fix copyright headers ref. 14748413906 |
@FraserGreenroyd I have queued up your request to fix copyright headers. There are 0 requests in the queue ahead of you. |
@FraserGreenroyd I am now going to fix the copyright compliance in accordance with the annotations previously made. |
@FraserGreenroyd to confirm I have now resolved the copyright compliance and pushed a commit to this Pull Request. |
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check required |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 8 requests in the queue ahead of you. |
The check |
The check |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewing in @pawelbaran absence - tests make sense as a starting point, we can add more as we go 👍 😄
@BHoMBot check unit-tests |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
Issues addressed by this PR
Closes #162
After discussion in #161, it is clear that having a more robust and rapid testing process would help in responding to queries in this toolkit. This PR adds some basic tests done in support of #161's evaluation.
Changelog
Additional comments