Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ProjectIdEvent with FileId #368

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

travispotterBH
Copy link

Issues addressed by this PR

Analytics Pop-up should not appear if Excel's Info --> Title property is filled out prior to BHoM method call.

Closes #367

Project ID Event is set with appropriate file id to allow LINQ filtering to collect the event from other logged events.
Project Id gets set before execution of pop-up window if project information project number is set.

Changelog

  • Added FileId to ProjectIDEvent

Additional comments

@travispotterBH
Copy link
Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 8, 2022

@travispotterBH to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes make sense and resolve the issue we've been chasing down.

@travispotterBH travispotterBH added the type:bug Error or unexpected behaviour label Nov 8, 2022
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 8, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 11 requests in the queue ahead of you.

@travispotterBH
Copy link
Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 8, 2022

@travispotterBH to confirm, the following actions are now queued:

  • check versioning

There are 19 requests in the queue ahead of you.

@travispotterBH
Copy link
Author

@BHoMBot check versioning
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 8, 2022

@travispotterBH to confirm, the following actions are now queued:

  • check versioning
  • check ready-to-merge

@travispotterBH
Copy link
Author

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 8, 2022

@travispotterBH to confirm, the following actions are now queued:

  • check copyright-compliance

@FraserGreenroyd FraserGreenroyd merged commit 1af5e4f into main Nov 8, 2022
@FraserGreenroyd FraserGreenroyd deleted the Excel_UI-#367-SetProjectIdEventWithFileId branch November 8, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analytics Pop-up appears though Excel Title Info is filled out
2 participants