-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash on load for Excel sheets with Datasets #366
Fix crash on load for Excel sheets with Datasets #366
Conversation
…ck as extra protection
@IsakNaslundBh to confirm, the following actions are now queued:
|
The check |
The check |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes are sensible and good protections added.
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
NOTE: Depends on
Issues addressed by this PR
Closes #365
Only call UpdateEnumValues for relevant caller types and add null check as extra protection
Test files
in fresh Excelsheet:
Add dataset (any dataset)
Add some other method
Save and close
Reopen sheet
Changelog
Additional comments