-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Refactoring #243
UI Refactoring #243
Conversation
@IsakNaslundBh , I think I have fixed the issues you mentioned above. Let me know if you still have problems |
So think all first issues found fixed 👍 |
OK, I think I might have finally fixed the bug with Excel crashing when closing. I say might because this thing is very elusive but I haven't had the crash for the last 10+ times I have pen Excel so that's a good sign. The weird thing is that the bug was related to registering to the WorkbookOpened event. After a lot of trial ad errors, it sees that this version is not crashing anymore 🤞 . For the record, every detail of the change is important. Even keeping Let me know if you still notice the problem after this commit. Edit: Trying to access the hidden sheet for internalised data still causes the bug (regardless of the sheet existing or not). It doesn't make sense since it is the exact same process as accessing the hidden sheet for caller but i'll just disable that for now until I found a solution to it. At least the bug doesn't occur on WorkbookOpened event anymore. Edit2: Using NetOffice to try to access a sheet seems to be causing the same bug at closing time. Conclusion -> Let's get rid of that package. |
have opened and closed excel ~20 times in a row now with no crash. Given the nature of the bug, that ofc does not guarantee anything, but if not gone, it at least seem to have improved it significantly! |
For those that have already created new Excel spreadsheet with this PR: In order to add support to multiple workbooks being opened at the same time, I had to slightly modify the structure of the sheet used to save the list of used components. This mean that, while your Excel file will still open, it will not be able to execute the existing BHoM formulas correctly. Here's how to fix this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This so LGTM!
Great stuff @adecler
As discussed ready for wider alpha testing on master!
/azp run Excel_Toolkit.CheckInstaller |
Azure Pipelines successfully started running 1 pipeline(s). |
NOTE: Depends on
BHoM/BHoM_UI#297
Issues addressed by this PR
See BHoM/BHoM_UI#297 for details
See comment below: https://github.com/BHoM/Excel_Toolkit/pull/243#issuecomment-678620148
Also fixes a series of pre-existing issues:
Fixes #242
Fixes #233
Fixes #218
Fixes #187
Fixes #149
Fixes #240
Fixes #244
Test files
Changelog
Additional comments