Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for stream in the adapter #41

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

adecler
Copy link
Member

@adecler adecler commented Nov 5, 2023

@adecler adecler added the type:feature New capability or enhancement label Nov 5, 2023
@adecler adecler self-assigned this Nov 5, 2023
Copy link

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have built this PR and produced a local nuget for testing with the workflow desired. The test downloaded the Excel report and contained data for display as expected.

I've reviewed the code and see no issues with that either, so happy to deploy this to develop for further testing via alpha nugets and alpha installers 😄

@FraserGreenroyd
Copy link

@BHoMBot check compliance
@BHoMBot check required

Copy link

bhombot-ci bot commented Nov 7, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link

bhombot-ci bot commented Nov 7, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Nov 7, 2023

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Excel_Adapter/ExcelAdapter.cs Outdated Show resolved Hide resolved
@FraserGreenroyd
Copy link

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Nov 7, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@FraserGreenroyd
Copy link

@BHoMBot check required

Copy link

bhombot-ci bot commented Nov 7, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link

bhombot-ci bot commented Nov 7, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Nov 7, 2023

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Nov 7, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Nov 7, 2023

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is installer.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 18438046095

@FraserGreenroyd
Copy link

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 18438046095

Copy link

bhombot-ci bot commented Nov 7, 2023

@FraserGreenroyd I have now provided a passing check on reference 18438046095 as requested.

@FraserGreenroyd
Copy link

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Nov 7, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

Copy link

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving following documentation updates

@FraserGreenroyd
Copy link

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Nov 7, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit f12d187 into develop Nov 7, 2023
12 checks passed
@FraserGreenroyd FraserGreenroyd deleted the template-zeroCodeWA-#6-reportDownload branch November 7, 2023 11:40
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants