-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for stream in the adapter #41
Add support for stream in the adapter #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have built this PR and produced a local nuget for testing with the workflow desired. The test downloaded the Excel report and contained data for display as expected.
I've reviewed the code and see no issues with that either, so happy to deploy this to develop
for further testing via alpha nugets and alpha installers 😄
@FraserGreenroyd to confirm, the following actions are now queued:
|
The check |
The check |
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check required |
@FraserGreenroyd to confirm, the following actions are now queued:
|
The check |
The check |
The check |
FAO: @FraserGreenroyd The check they wish to have dispensation on is installer. If you are providing dispensation on this occasion, please reply with:
|
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 18438046095 |
@FraserGreenroyd I have now provided a passing check on reference |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving following documentation updates
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
NOTE: Provides support to
https://github.com/BuroHappoldEngineering/template-zeroCodeWA/pull/11
Issues addressed by this PR
See PR https://github.com/BuroHappoldEngineering/template-zeroCodeWA/pull/11
Test files
Will be tested in PR https://github.com/BuroHappoldEngineering/template-zeroCodeWA/pull/11
Changelog