Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excel_Toolkit: Improved UX for adapter pull #38

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Excel_Toolkit: Improved UX for adapter pull #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
417a5bd
Improved UX for adapter pull
albinber Sep 6, 2023
d79ef09
Changed Input description
albinber Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Excel_Engine/Create/CellContentsRequest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ public static partial class Create

[Description("Creates a CellContentsRequest based on the worksheet name and range in an Excel-readable string format.")]
[InputFromProperty("worksheet")]
[Input("range", "Cell range in an Excel-readable string format.")]
[Input("range", "Cell range in an Excel-readable string format. If no range provided the default will be for the whole worksheet starting from A1 and extending to the extents of the used range in the worksheet.")]
[Output("request", "CellContentsRequest created based on the input strings.")]
public static CellContentsRequest CellContentsRequest(string worksheet, string range)
public static CellContentsRequest CellContentsRequest(string worksheet, string range = "")
{
CellRange cellRange = null;
if (!string.IsNullOrWhiteSpace(range))
Expand Down
2 changes: 2 additions & 0 deletions Excel_oM/Requests/CellContentsRequest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,12 @@
using BH.oM.Data.Requests;
using System.Collections.Generic;
using System.ComponentModel;
using BH.oM.Base.Attributes;

namespace BH.oM.Adapters.Excel
{
[Description("IRequest that pulls cells and their metadata from the excel file.")]
[NoAutoConstructor]
public class CellContentsRequest : IRequest
{
/***************************************************/
Expand Down