Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nuspec file #36

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Add nuspec file #36

merged 1 commit into from
Aug 14, 2023

Conversation

FraserGreenroyd
Copy link

Fixes #35

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Aug 14, 2023
@FraserGreenroyd FraserGreenroyd self-assigned this Aug 14, 2023
@FraserGreenroyd
Copy link
Author

@BHoMBot check compliance
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 14, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for me, have installed alpha and built successfully.

Only comment is whether we would want to add the BHoM version on L5 - would add one more thing BHoMBot needs to update every milestone but could be worth it?

@FraserGreenroyd
Copy link
Author

Only comment is whether we would want to add the BHoM version on L5 - would add one more thing BHoMBot needs to update every milestone but could be worth it?

Not worth it - the version changes with every build for Nuget, so the bot handles inserting the appropriate version number when the nuget is built based on the milestone and sprint that we're currently in 😄

@FraserGreenroyd
Copy link
Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 14, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit c01a3f9 into develop Aug 14, 2023
@FraserGreenroyd FraserGreenroyd deleted the Excel_Toolkit-#35-Nuspec branch August 14, 2023 13:40
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add nuspec file to allow for nugets
2 participants