Adding GetEvents component #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adecler
requested review from
alelom,
al-fisher,
FraserGreenroyd and
IsakNaslundBh
pawelbaran
approved these changes
Nov 5, 2020
|
/azp run Dynamo_Toolkit.CheckInstaller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pawelbaran
requested changes
Nov 6, 2020
|
@pawelbaran , this didn't crash for me. Did you follow the procedure in the That being said, when testing for the crash, I noticed I couldn't create the |
pawelbaran
approved these changes
Nov 12, 2020
|
/azp run Dynamo_Toolkit.CheckInstaller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
BHoM/BHoM_UI#331
Issues addressed by this PR
See BHoM/BHoM_UI#331
Additional comments
If you found yourself in the situation where the component fails (silently) to create itself, make sure to manually clean the BHoM folders in
AppData\Roaming\Dynamofor 2.3 (core and Revit). It seems that the installer is still copying the dlls there therefore creating a conflict with the dll inProgramData/BHoM.