Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lifespan datatype #132

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Fix lifespan datatype #132

merged 2 commits into from
Sep 13, 2024

Conversation

michaelhoehn
Copy link
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #131

Test files

Test file

Changelog

Additional comments

@michaelhoehn michaelhoehn added the type:bug Error or unexpected behaviour label Aug 1, 2024
@michaelhoehn michaelhoehn self-assigned this Aug 1, 2024
enarhi
enarhi approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@enarhi enarhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, used test script and was able to successfully pull EPD's from EC3 using the NameLike filter.

@michaelhoehn
lazy fix
6001fe5
@michaelhoehn
trycatch
9eb68e8 
EC3 API returns a string for this property and will break
@michaelhoehn michaelhoehn force-pushed the CarbonQueryDatabase_Toolkit-#131-NameLIke-bug branch from b25800a to 9eb68e8 Compare September 12, 2024 16:16
@michaelhoehn
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Sep 12, 2024

@michaelhoehn to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@michaelhoehn
Copy link
Contributor Author

@BHoMBot check copyright-compliance

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Sep 12, 2024

@michaelhoehn to confirm, the following actions are now queued:

  • check copyright-compliance

@michaelhoehn
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Sep 12, 2024

@michaelhoehn to confirm, the following actions are now queued:

  • check ready-to-merge

@IsakNaslundBh IsakNaslundBh merged commit fd62047 into develop Sep 13, 2024
10 checks passed
@IsakNaslundBh IsakNaslundBh deleted the CarbonQueryDatabase_Toolkit-#131-NameLIke-bug branch September 13, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enarhi enarhi enarhi approved these changes

@ofekbruhis ofekbruhis Awaiting requested review from ofekbruhis

Assignees

@michaelhoehn michaelhoehn

Labels
type:bug Error or unexpected behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using NameLike produces an error
3 participants
@michaelhoehn @enarhi @IsakNaslundBh