Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AssemblyFileVersion to 7.0 #70

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Conversation

bhombot-ci[bot]
Copy link

@bhombot-ci bhombot-ci bot commented Sep 25, 2023

Update AssemblyFileVersion to 7.0

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Sep 25, 2023
@FraserGreenroyd FraserGreenroyd self-requested a review September 25, 2023 14:31
@bhombot-ci
Copy link
Author

bhombot-ci bot commented Sep 25, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on SQL_Toolkit

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check project-compliance

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Sep 25, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check project-compliance

There are 59 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check project-compliance

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Sep 25, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check project-compliance

There are 59 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Sep 25, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 252 requests in the queue ahead of you.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRs have been spot checked by DevOps. Updates are in line with usual updates to AssemblyFileVersion. Approving for merge.

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Sep 25, 2023

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: core, null-handling, serialisation, versioning, ready-to-merge

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Sep 25, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: branch-compliance

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Sep 25, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit ed50b1b into develop Sep 25, 2023
12 checks passed
@FraserGreenroyd FraserGreenroyd deleted the BHoM-UpdateTo70 branch September 25, 2023 16:42
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants