Fix Rhino8 Crash With Analytics PopUp #498
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…running version of Rhino 3d
GCRA101
requested review from
alelom,
IsakNaslundBh,
Chrisshort92 and
peterjamesnugent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
related to https://github.com/BuroHappoldEngineering/BuroHappold_BHoMAnalytics_Toolkit/pull/67
Preventing the Analytics PopUp Window from popping up, Rhino8 doesn't crash anymore and it's possible to use the BHoM with Rhino8 models. In screenshots above, example of pull from Robot Model in Rhino 8 via the BHoM - all working fine.
Test files
Grasshopper File
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/BHoMAnalytics_Toolkit/%2366-FixRhino8CrashWithAnalyticsPopUp/Test%20Script.gh?csf=1&web=1&e=Ydog48
Robot File
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/BHoMAnalytics_Toolkit/%2366-FixRhino8CrashWithAnalyticsPopUp/[TestRobotModel.rtd](https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/BHoMAnalytics_Toolkit/%2366-FixRhino8CrashWithAnalyticsPopUp/TestRobotModel.rtd?csf=1&web=1&e=xIGmF5)?csf=1&web=1&e=xIGmF5
Changelog