Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix target framework in the nuspec file #494

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

adecler
Copy link
Member

@adecler adecler commented Aug 6, 2024

Issues addressed by this PR

Closes #493

Fairly straightforward. I simply removed the extra .0 in the target framework. So this should be pretty quick and easy to review.

@adecler adecler added the type:bug Error or unexpected behaviour label Aug 6, 2024
@adecler adecler self-assigned this Aug 6, 2024
@adecler
Copy link
Member Author

adecler commented Aug 6, 2024

@BHoMBot check required

Copy link

bhombot-ci bot commented Aug 6, 2024

@adecler to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 28 requests in the queue ahead of you.

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check copyright-compliance

Copy link

bhombot-ci bot commented Aug 7, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check copyright-compliance

There are 3 requests in the queue ahead of you.

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by code inspection and happy with the change.

@adecler
Copy link
Member Author

adecler commented Aug 7, 2024

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Aug 7, 2024

@adecler to confirm, the following actions are now queued:

  • check ready-to-merge

There are 11 requests in the queue ahead of you.

@adecler adecler merged commit a91a77e into develop Aug 7, 2024
10 checks passed
@adecler adecler deleted the BHoM_UI-#493-FixTargetFramework branch August 7, 2024 08:27
@BHoMBot BHoMBot mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the nuspec template file to reference the correct framework
2 participants