Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect against OnDocumentEndOpening not setting m_documentOpening to false #440

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Protect against OnDocumentEndOpening not setting m_documentOpening to false #440

merged 1 commit into from
Nov 30, 2022

Conversation

FraserGreenroyd
Copy link
Contributor

Issues addressed by this PR

Fixes #439

Test files

Changelog

Additional comments

@FraserGreenroyd FraserGreenroyd added the type:bug Error or unexpected behaviour label Nov 30, 2022
@FraserGreenroyd FraserGreenroyd self-assigned this Nov 30, 2022
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 30, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check copyright-compliance
@BHoMBot check project-compliance
@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 30, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance
  • check project-compliance
  • check core

jamesramsden-bh
jamesramsden-bh approved these changes Nov 30, 2022
View reviewed changes
Copy link

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened new GH file, popup appeared. Ran a few BHoM methods and log files appeared to be created correctly. Nothing else broke along the way.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 30, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 68e4690 into main Nov 30, 2022
@FraserGreenroyd FraserGreenroyd deleted the BHoM_UI-#439-AlwaysTrue branch November 30, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesramsden-bh jamesramsden-bh jamesramsden-bh approved these changes

Assignees

@FraserGreenroyd FraserGreenroyd

Labels
type:bug Error or unexpected behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

m_documentOpening always true when loading blank script
2 participants
@FraserGreenroyd @jamesramsden-bh