Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger for UI Loading events during analytics logging #438

Merged
merged 4 commits into from
Nov 24, 2022

Conversation

FraserGreenroyd
Copy link
Contributor

Issues addressed by this PR

Fixes #437

Test files

Changelog

Additional comments

@FraserGreenroyd FraserGreenroyd added the type:bug Error or unexpected behaviour label Nov 24, 2022
@FraserGreenroyd FraserGreenroyd self-assigned this Nov 24, 2022
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check versioning
@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning
  • check installer

There are 20 requests in the queue ahead of you.

Copy link

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, reopening a previously assigned script now no longer triggers the analytics popup. Changing the project number, saving, and reopening the script triggers the popup again on GH recalculation.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 8 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 27 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2022

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2022

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance

There are 14 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: core, installer, project-compliance, ready-to-merge, versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2022

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance

There are 5 requests in the queue ahead of you.

Copy link

@CKBoulter CKBoulter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving following copyright updates based on functionality review previously provided.

@FraserGreenroyd FraserGreenroyd merged commit 840f0bd into main Nov 24, 2022
@FraserGreenroyd FraserGreenroyd deleted the BHoM_UI-#437-RaceCondition branch November 24, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Race Condition in loading scripts
3 participants