-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger for UI Loading events during analytics logging #438
Conversation
@BHoMBot check versioning |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check installer |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@FraserGreenroyd to confirm, the following actions are now queued:
There are 20 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, reopening a previously assigned script now no longer triggers the analytics popup. Changing the project number, saving, and reopening the script triggers the popup again on GH recalculation.
@BHoMBot check required |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 8 requests in the queue ahead of you. |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 27 requests in the queue ahead of you. |
The check |
The check |
@BHoMBot check copyright-compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 14 requests in the queue ahead of you. |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: core, installer, project-compliance, ready-to-merge, versioning |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
@BHoMBot check copyright-compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 5 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving following copyright updates based on functionality review previously provided.
Issues addressed by this PR
Fixes #437
Test files
Changelog
Additional comments