Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add event to be triggered when the UI is closing #435

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Add event to be triggered when the UI is closing #435

merged 1 commit into from
Nov 2, 2022

Conversation

FraserGreenroyd
Copy link
Contributor

Issues addressed by this PR

Fixes #434

Test files

Changelog

Additional comments

@FraserGreenroyd FraserGreenroyd added the type:feature New capability or enhancement label Nov 2, 2022
@FraserGreenroyd FraserGreenroyd self-assigned this Nov 2, 2022
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 2, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 2, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check versioning

There are 5 requests in the queue ahead of you.

kprusicka
kprusicka approved these changes Nov 2, 2022
View reviewed changes
Copy link

@kprusicka kprusicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks incredible to me

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 2, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 4 requests in the queue ahead of you.

travispotterBH
travispotterBH approved these changes Nov 2, 2022
View reviewed changes
Copy link

@travispotterBH travispotterBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log is amended at closing for Excel document:
image

@FraserGreenroyd FraserGreenroyd merged commit ca958e0 into main Nov 2, 2022
@FraserGreenroyd FraserGreenroyd deleted the BHoM_UI-#434-EventOnClose branch November 2, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kprusicka kprusicka kprusicka approved these changes

@travispotterBH travispotterBH travispotterBH approved these changes

@michaelhoehn michaelhoehn Awaiting requested review from michaelhoehn

@alexissantella alexissantella Awaiting requested review from alexissantella

Assignees

@FraserGreenroyd FraserGreenroyd

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an event to be triggered when the UI is closed
3 participants
@FraserGreenroyd @travispotterBH @kprusicka