Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to query the usage log file name for external toolkits to the UI #433

Merged
merged 4 commits into from
Nov 1, 2022
Merged

Add ability to query the usage log file name for external toolkits to the UI #433

merged 4 commits into from
Nov 1, 2022

Conversation

FraserGreenroyd
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd commented Nov 1, 2022 •
edited
Loading

Issues addressed by this PR

Fixes #432
Fixes #431

Test files

Changelog

Additional comments

@FraserGreenroyd FraserGreenroyd added the type:feature New capability or enhancement label Nov 1, 2022
@FraserGreenroyd FraserGreenroyd self-assigned this Nov 1, 2022
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 1, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 3 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 1, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 1, 2022

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

kprusicka
kprusicka reviewed Nov 1, 2022
View reviewed changes
Copy link

@kprusicka kprusicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

kprusicka
kprusicka approved these changes Nov 1, 2022
View reviewed changes
Copy link

@kprusicka kprusicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never seen anything more perfect.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 1, 2022

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 1, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 1 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit 2264029 into main Nov 1, 2022
@FraserGreenroyd FraserGreenroyd deleted the BHoM_UI-#432-UsageLogFile branch November 1, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kprusicka kprusicka kprusicka approved these changes

@michaelhoehn michaelhoehn Awaiting requested review from michaelhoehn

@alexissantella alexissantella Awaiting requested review from alexissantella

@travispotterBH travispotterBH Awaiting requested review from travispotterBH

Assignees

@FraserGreenroyd FraserGreenroyd

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query to get the current usage log file Extend deprecation period for usage logs
2 participants
@FraserGreenroyd @kprusicka