Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Explode component behaviour when object has some non-retrievable properties #424

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

alelom
Copy link
Member

@alelom alelom commented Aug 8, 2022

Issues addressed by this PR

Closes #423

Test files

See #423 for the test script.

Before this PR, the script will return an error on the Explode component, returning no output (not even for the retrievable properties).
After this PR, the script should behave as this:
image

Changelog

Additional comments

@alelom alelom requested a review from FraserGreenroyd August 8, 2022 15:52
@alelom alelom self-assigned this Aug 8, 2022
@alelom alelom added type:bug Error or unexpected behaviour size:S Measured in minutes priority:low Resources should be targeted to other issues first labels Aug 8, 2022
@alelom alelom changed the title Fixes #423 Improving the Explode component behaviour when dealing with non-retrievable properties Aug 8, 2022
@alelom alelom changed the title Improving the Explode component behaviour when dealing with non-retrievable properties Improve Explode component behaviour when object has some non-retrievable properties Aug 8, 2022
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 9, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 2 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 9, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance
  • check ready-to-merge

There are 26 requests in the queue ahead of you.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look sensible, output looks fine on explode component.

@FraserGreenroyd FraserGreenroyd merged commit ba61783 into main Aug 9, 2022
@FraserGreenroyd FraserGreenroyd deleted the BHoM_UI-#423-ExplodeCatch branch August 9, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:low Resources should be targeted to other issues first size:S Measured in minutes type:bug Error or unexpected behaviour
Projects
None yet
2 participants