Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment_Engine: Add check for null Space perimeter in the IsValid method #2960

Merged
merged 2 commits into from
Dec 2, 2022
Merged

Environment_Engine: Add check for null Space perimeter in the IsValid method #2960

merged 2 commits into from
Dec 2, 2022

Conversation

FraserGreenroyd
Copy link
Contributor

Issues addressed by this PR

Fixes #2959

Test files

See Issue

@FraserGreenroyd FraserGreenroyd added the type:feature New capability or enhancement label Dec 2, 2022
@FraserGreenroyd FraserGreenroyd self-assigned this Dec 2, 2022
@FraserGreenroyd FraserGreenroyd marked this pull request as ready for review December 2, 2022 14:46
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 2, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 2, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

There are 12 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 2, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests

There are 2 requests in the queue ahead of you.

michaelhoehn
michaelhoehn approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@michaelhoehn michaelhoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Ready to merge.

rboulton-BH
rboulton-BH reviewed Dec 2, 2022
View reviewed changes
Copy link
Contributor

@rboulton-BH rboulton-BH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this PR using the script proposed in the Issue it addresses and the fix performs flawlessly. This PR is a truly remarkable solution to the problem at hand. Highly commendable work by all those who contributed. Huzzah

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 2, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check null-handling
  • check serialisation
  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 257d047 into main Dec 2, 2022
@FraserGreenroyd FraserGreenroyd deleted the Environment_Engine-#2959-NullSpacePerimeter branch December 2, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rboulton-BH rboulton-BH rboulton-BH left review comments

@michaelhoehn michaelhoehn michaelhoehn approved these changes

@kprusicka kprusicka Awaiting requested review from kprusicka

@CKBoulter CKBoulter Awaiting requested review from CKBoulter

@tg359 tg359 Awaiting requested review from tg359 tg359 is a code owner

Assignees

@FraserGreenroyd FraserGreenroyd

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Environment_Engine: IsValid(Spaces) method to handle null perimeter
3 participants
@FraserGreenroyd @rboulton-BH @michaelhoehn