Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facade_Engine: Update Methods to Handle UValueCavity Fragment #2955

Merged
merged 3 commits into from
Dec 2, 2022

Conversation

vgreen-BH
Copy link
Contributor

Issues addressed by this PR

Closes #2951

  • Updated UValueOpeningAW method to handle construction fragment UValueCavity
  • Updated UValuePanelAW method to handle construction fragment UValueCavity

Test files

https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/03_Alpha/BHoM/BHoM_Engine/Facade_Engine/BHoM%20PR%20Test%20Files/Facade_Engine-Cavity%20Insulation%20Test%20File.gh?csf=1&web=1&e=H9metl

UValue AW methods updated to handle cavity u-value and continuous u-value
@vgreen-BH vgreen-BH added the type:feature New capability or enhancement label Nov 29, 2022
@vgreen-BH vgreen-BH added this to the BHoM 6.0 β MVP milestone Nov 29, 2022
@vgreen-BH vgreen-BH requested a review from enarhi November 29, 2022 01:17
@vgreen-BH vgreen-BH requested a review from al-fisher as a code owner November 29, 2022 01:17
@vgreen-BH vgreen-BH self-assigned this Nov 29, 2022
@enarhi
Copy link
Member

enarhi commented Nov 29, 2022

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 29, 2022

@enarhi to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@enarhi
Copy link
Member

enarhi commented Nov 30, 2022

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 30, 2022

@enarhi to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 30, 2022

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 30, 2022

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

enarhi
enarhi previously approved these changes Nov 30, 2022
Copy link
Member

@enarhi enarhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested using provided test script for all possible U Value combos for panels and openings per the script, and all results and error handling were as expected. Tested tweaking values along the way as well to confirm functionality for various result value combos.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 30, 2022

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get some unit tests for new features added please 😄

@enarhi
Copy link
Member

enarhi commented Dec 2, 2022

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 2, 2022

@enarhi to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@enarhi
Copy link
Member

enarhi commented Dec 2, 2022

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 2, 2022

@enarhi to confirm, the following actions are now queued:

  • check unit-tests

There are 7 requests in the queue ahead of you.

@enarhi
Copy link
Member

enarhi commented Dec 2, 2022

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 2, 2022

@enarhi to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 4 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 2, 2022

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 2, 2022

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Member

@enarhi enarhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as per previous review and passing of appropriate relevant Unit Tests

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 2, 2022

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@enarhi
Copy link
Member

enarhi commented Dec 2, 2022

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 2, 2022

@enarhi to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 3481ef7 into main Dec 2, 2022
@FraserGreenroyd FraserGreenroyd deleted the Facade_Enginer-#2951-UpdateUValeAWMethods branch December 2, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facade_Engine: Update Methods to Handle UValueCavity Fragment
3 participants