Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialiser_Engine: Fix serialisation in Blazor web assemblies #2954

Merged
merged 2 commits into from
Nov 24, 2022

Conversation

adecler
Copy link
Member

@adecler adecler commented Nov 24, 2022

Issues addressed by this PR

Closes #2953

Two things are being fixed:

  • Check that the C:\ProgramData\BHoM\Upgrades folder exists before collecting Versioning upgraders to prevent errors in web apps.
  • Filter out dynamic assemblies when extracting types as the call to the ReflectionOnly property is throwing an exception for them.

Test files

Test of the fix ran in a live session with @FraserGreenroyd as it requires testing the fix within a Blazor application.

@adecler adecler added the type:bug Error or unexpected behaviour label Nov 24, 2022
@adecler adecler self-assigned this Nov 24, 2022
@adecler
Copy link
Member Author

adecler commented Nov 24, 2022

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2022

@adecler to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 1 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd changed the title Fix serialisation in Blazor web assemblies Serialiser_Engine: Fix serialisation in Blazor web assemblies Nov 24, 2022
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 16 requests in the queue ahead of you.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes make sense and tested on demo with @adecler as mentioned, happy to approve for merge.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2022

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2022

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2022

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check unit-tests
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests
  • check ready-to-merge

There are 52 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit 670ee62 into main Nov 24, 2022
@FraserGreenroyd FraserGreenroyd deleted the BHoM_Engine-#2953-FixSerialisationInBlazor branch November 24, 2022 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serialiser crashes when used in Blazor web assemblies
2 participants