-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialiser_Engine: Fix serialisation in Blazor web assemblies #2954
Serialiser_Engine: Fix serialisation in Blazor web assemblies #2954
Conversation
@BHoMBot check compliance |
@adecler to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
@BHoMBot check required |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 16 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes make sense and tested on demo with @adecler as mentioned, happy to approve for merge.
The check |
The check |
The check |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 52 requests in the queue ahead of you. |
Issues addressed by this PR
Closes #2953
Two things are being fixed:
C:\ProgramData\BHoM\Upgrades
folder exists before collecting Versioning upgraders to prevent errors in web apps.ReflectionOnly
property is throwing an exception for them.Test files
Test of the fix ran in a live session with @FraserGreenroyd as it requires testing the fix within a Blazor application.