-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geometry_Engine: Add join mesh method and fix MergeVertices #2947
Conversation
Method was not at all functioning before, so complete refactor, making use of methods not existing when method was added Rename from MergedVertices to MergeVertices to align with general naming convetion of methods
@BHoMBot check compliance |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 19 requests in the queue ahead of you. |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 30 requests in the queue ahead of you. |
The check |
The check |
The check |
The check |
@BHoMBot check compliance |
@IsakNaslundBh to confirm, the following actions are now queued:
|
@pawelbaran to confirm, the following actions are now queued:
|
The check |
The check |
The check |
The check |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on the code review, answered comments as well as testing made using provided test file as well as in promptu performance tests, which showed there is still space for improvement in finding duplicate points (but this refers to BHoM cull duplicate methods in general).
@pawelbaran to confirm, the following actions are now queued:
|
Issues addressed by this PR
Closes #2945
Closes #2946
Test files
https://burohappold.sharepoint.com/:f:/s/BHoM/Eo4Nblb9345DlWdrFSNZwx8BwNsgwKB74BxCuqah5qCYPg?e=Hmavj2
Changelog
Additional comments