Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry_Engine: Add PointAtParameter for ellipse #2937

Merged
merged 3 commits into from
Oct 31, 2022

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented Oct 28, 2022

Issues addressed by this PR

Closes #2936

Add implementation of PointAtParameter for ellipse.

Implementation added does not correspond to normalised length along the curve but rather normalised angle along the curve, which for the case of an ellipse imo is a more sensical way of dealing with it.

Also adding Descriptions and null checking for all methods

Test files

https://burohappold.sharepoint.com/:f:/s/BHoM/ErnhG5n6ug5LkVRjjCCMZdkBKOiY6hE7Sz0UEKsxwgIUAw?e=Efi4Rd

Changelog

Additional comments

Also adding Descriptions and null checking for all methods
@IsakNaslundBh IsakNaslundBh added the type:feature New capability or enhancement label Oct 28, 2022
@IsakNaslundBh IsakNaslundBh requested a review from alelom October 28, 2022 10:26
@IsakNaslundBh IsakNaslundBh self-assigned this Oct 28, 2022
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check unit-tests
@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 28, 2022

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check unit-tests
  • check null-handling

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check unit-tests
@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 28, 2022

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check unit-tests
  • check null-handling

Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve after code review and testing 👍

@pawelbaran
Copy link
Member

@BHoMBot check core
@BHoMBot check serialisation
@BHoMBot check versioning
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 28, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check core
  • check serialisation
  • check versioning
  • check ready-to-merge

@IsakNaslundBh IsakNaslundBh merged commit 440fb1c into main Oct 31, 2022
@IsakNaslundBh IsakNaslundBh deleted the Geometry_Engine-#2936-PointAtParameterEllipse branch October 31, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geometry_Engine: Add missing PointAtParameter for ellipse
2 participants