-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geometry_Engine: Add PointAtParameter for ellipse #2937
Merged
IsakNaslundBh
merged 3 commits into
main
from
Geometry_Engine-#2936-PointAtParameterEllipse
Oct 31, 2022
Merged
Geometry_Engine: Add PointAtParameter for ellipse #2937
IsakNaslundBh
merged 3 commits into
main
from
Geometry_Engine-#2936-PointAtParameterEllipse
Oct 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adding Descriptions and null checking for all methods
IsakNaslundBh
requested review from
pawelbaran,
al-fisher and
epignatelli
as code owners
October 28, 2022 10:26
@IsakNaslundBh to confirm, the following actions are now queued:
|
@IsakNaslundBh to confirm, the following actions are now queued:
|
pawelbaran
approved these changes
Oct 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to approve after code review and testing 👍
@pawelbaran to confirm, the following actions are now queued:
|
IsakNaslundBh
deleted the
Geometry_Engine-#2936-PointAtParameterEllipse
branch
October 31, 2022 07:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #2936
Add implementation of PointAtParameter for ellipse.
Implementation added does not correspond to normalised length along the curve but rather normalised angle along the curve, which for the case of an ellipse imo is a more sensical way of dealing with it.
Also adding Descriptions and null checking for all methods
Test files
https://burohappold.sharepoint.com/:f:/s/BHoM/ErnhG5n6ug5LkVRjjCCMZdkBKOiY6hE7Sz0UEKsxwgIUAw?e=Efi4Rd
Changelog
Additional comments