-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matter_Engine: Improve Density Management for Physical materials #2935
Matter_Engine: Improve Density Management for Physical materials #2935
Conversation
… extraction of densities
… to options Will test in UI and remove if not functioning as intended
…use method when creating materials and setting density to match properties
@IsakNaslundBh to confirm, the following actions are now queued:
|
@BHoMBot check unit-tests |
@IsakNaslundBh to confirm, the following actions are now queued:
|
Have investigated the failing UTs for VolumetricMaterialTakeoff and MaterialComposition and both boils down to the same reason for the failure. Both failing cases are that the density is set to 7850 when run on this branch, while on main the non-existing value returned is 0: Creating a composition or takeoff straight from a structural material it is valid to pass the density to the physical material, hence the change in behaviour is expected and an improvement. Will for those reasons regenerate those UTs to what is returned on this branch. |
@BHoMBot check unit-tests |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 2 requests in the queue ahead of you. |
@BHoMBot check compliance |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 2 requests in the queue ahead of you. |
@BHoMBot check versioning |
@IsakNaslundBh to confirm, the following actions are now queued:
|
@IsakNaslundBh just to let you know, I have provided a |
@BHoMBot check unit-tests |
@IsakNaslundBh to confirm, the following actions are now queued:
|
@BHoMBot check versioning |
@IsakNaslundBh to confirm, the following actions are now queued:
|
@IsakNaslundBh just to let you know, I have provided a |
@BHoMBot check compliance |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 9 requests in the queue ahead of you. |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 10 requests in the queue ahead of you. |
@BHoMBot check core |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 17 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on review and commentary in oM PR - see BHoM/BHoM#1443
@BHoMBot check ready-to-merge |
@al-fisher to confirm, the following actions are now queued:
There are 2 requests in the queue ahead of you. |
NOTE: Depends on
BHoM/BHoM#1443
Issues addressed by this PR
Test files
https://burohappold.sharepoint.com/:f:/s/BHoM/Eg7Y5NfGykJKr5Bc1wfki6ABOXhTCqmW-pr3oNrYvFzKYA?e=tJxtni
Changelog
Additional comments