Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reflection_Engine: Add a check to filter out non-BH Types from the IsPrototype check #2920

Merged
merged 5 commits into from
Oct 4, 2022
Merged

Reflection_Engine: Add a check to filter out non-BH Types from the IsPrototype check #2920

merged 5 commits into from
Oct 4, 2022

Conversation

FraserGreenroyd
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd commented Oct 3, 2022 •
edited
Loading

Issues addressed by this PR

Fixes #2913

Test files

Here is a test script

Changelog

Additional comments

@FraserGreenroyd FraserGreenroyd added the type:bug Error or unexpected behaviour label Oct 3, 2022
@FraserGreenroyd FraserGreenroyd self-assigned this Oct 3, 2022
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 3, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests

There are 25 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 3, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core

There are 17 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 3, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests

@FraserGreenroyd
Copy link
Contributor Author

@IsakNaslundBh one for us to investigate in the morning I think, the unit test is passing locally but failing on the PR when it was made for this PR...!

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 4, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 4, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 4, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 4, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 4, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests

@FraserGreenroyd
Copy link
Contributor Author

FraserGreenroyd commented Oct 4, 2022 •
edited
Loading

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 4, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 4, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 4, 2022

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 4, 2022

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 4, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 4, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check dataset-compliance

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 4, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check dataset-compliance

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 4, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check dataset-compliance

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a DevOps action. I am requesting a force check on: dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 4, 2022

@FraserGreenroyd sorry, I didn't understand.
Was that comment an instruction for me? If so, could you state again what check you would like me to do?
For a list of available instructions, please see this wiki page.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am requesting a force check on: dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 4, 2022

@FraserGreenroyd I am now running force checks on the checks requested. These will be queued and actioned ASAP.

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 4, 2022

@FraserGreenroyd I have provided force checks to the checks requested.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am requesting a force check on: dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 4, 2022

@FraserGreenroyd I am now running force checks on the checks requested. These will be queued and actioned ASAP.

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 4, 2022

@FraserGreenroyd I have provided force checks to the checks requested.

jamesramsden-bh
jamesramsden-bh approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamesramsden-bh
Copy link
Contributor

jamesramsden-bh commented Oct 4, 2022 •
edited by FraserGreenroyd
Loading

@BHoMBot check ready-to-merge

@jamesramsden-bh jamesramsden-bh self-requested a review October 4, 2022 16:12
@bhombot-ci
Copy link

bhombot-ci bot commented Oct 4, 2022

@jamesramsden-bh to confirm, the following actions are now queued:

  • check ready-to-merge

jamesramsden-bh
jamesramsden-bh approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed functionality demonstrated in GH with BHoM and non-BHoM types, works as expected.

@FraserGreenroyd FraserGreenroyd merged commit 4217ecc into main Oct 4, 2022
@FraserGreenroyd FraserGreenroyd deleted the Reflection_Engine-#2913-PrototypeSytstemBug branch October 4, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesramsden-bh jamesramsden-bh jamesramsden-bh approved these changes

@IsakNaslundBh IsakNaslundBh Awaiting requested review from IsakNaslundBh

@michaelhoehn michaelhoehn Awaiting requested review from michaelhoehn

@alexissantella alexissantella Awaiting requested review from alexissantella

@travispotterBH travispotterBH Awaiting requested review from travispotterBH

@adecler adecler Awaiting requested review from adecler adecler is a code owner

Assignees

@FraserGreenroyd FraserGreenroyd

Labels
type:bug Error or unexpected behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reflection_Engine: System types are flagged as prototypes
2 participants
@FraserGreenroyd @jamesramsden-bh