Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 5.3 Previous Version Attributes #2915

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Remove 5.3 Previous Version Attributes #2915

merged 1 commit into from
Sep 27, 2022

Conversation

BHoMBot
Copy link
Member

@BHoMBot BHoMBot commented Sep 27, 2022

Remove 5.3 Previous Version Attributes

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Sep 27, 2022
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 27, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 27, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

@FraserGreenroyd
Copy link
Contributor

FraserGreenroyd commented Sep 27, 2022 •
edited
Loading

@BHoMBot check code-compliance
@BHoMBot check documentation-compliance
@BHoMBot check dataset-compliance
@BHoMBot check project-compliance
@BHoMBot check copyright-compliance
@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 27, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check dataset-compliance
  • check project-compliance
  • check copyright-compliance
  • check core
  • check null-handling
  • check serialisation

FraserGreenroyd
FraserGreenroyd approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from a DevOps perspective after code review.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 27, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 10 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 27, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests

There are 3 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit 0d27757 into main Sep 27, 2022
@FraserGreenroyd FraserGreenroyd deleted the BHoM-RemovePreviousVersion53 branch September 27, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@tg359 tg359 Awaiting requested review from tg359 tg359 is a code owner

@al-fisher al-fisher Awaiting requested review from al-fisher al-fisher is a code owner

@rwemay rwemay Awaiting requested review from rwemay rwemay is a code owner

@IsakNaslundBh IsakNaslundBh Awaiting requested review from IsakNaslundBh IsakNaslundBh is a code owner

Assignees

@BHoMBot BHoMBot

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BHoMBot @FraserGreenroyd