Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structure_Engine: Add wall(panel) and floor(panel) and SurfaceElement(panel) #2883

Merged
merged 17 commits into from
Aug 9, 2022
Merged

Structure_Engine: Add wall(panel) and floor(panel) and SurfaceElement(panel) #2883

merged 17 commits into from
Aug 9, 2022

Conversation

JosefTaylor
Copy link
Contributor

@JosefTaylor JosefTaylor commented Jul 8, 2022 •
edited
Loading

NOTE: Depends on

Issues addressed by this PR

Closes #2881
Closes #2882

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/BHoM_Engine/Structure_Engine/%232883-AddSurfaceElementFromPanel?csf=1&web=1&e=cL8u2i

Changelog

  • Fixed bug in Physical.Create.Wall which ignored internal edges
  • Added Wall(Panel), Floor(Panel) and ISurface(Panel, usage) to convert panels to physical surface elements
  • Added IConstruction(ISurfaceProperty) to convert surface properties into Physical IConstructions. Convert to maintain total depth and material quantities, but may not accurately reflect geometry or structural properties of the SurfaceProperty. Ribbed properties will contain a void layer to reflect the missing concrete. Thus, it is not a 1:1 translation, until Physical IConstructions can represent the full range of objects represented by ISurfaceProperties.
  • Added IVolumePerArea(Construction) matching the IVolumePerArea(SurfaceProperty) which gets the effective thickness of solid materials (important for comparison to MaterialComposition in material takeoff)
  • Implemented IVolumePerArea() in SolidVolume() for ISurface and IOpening

Additional comments

@JosefTaylor
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 8, 2022

@JosefTaylor to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 2 requests in the queue ahead of you.

Compliance Cleanup
df1386c 
Descriptions in Construction.cs, splitting up SurfaceElements into three separate files, one for each return type.
@JosefTaylor
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 8, 2022

@JosefTaylor to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 4 requests in the queue ahead of you.

@JosefTaylor JosefTaylor changed the title Structure engine #2881 add wall(panel) and floor(panel) Structure_Engine: Add wall(panel) and floor(panel) and SurfaceElement(panel) Jul 8, 2022
@JosefTaylor
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 11, 2022

@JosefTaylor to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@JosefTaylor
Copy link
Contributor Author

@BHoMBot check code-compliance
@BHoMBot check documentation-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 11, 2022

@JosefTaylor to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance

@JosefTaylor
Copy link
Contributor Author

@BHoMBot check required

@JosefTaylor JosefTaylor requested a review from mchaf July 13, 2022 14:23
@JosefTaylor
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 13, 2022

@JosefTaylor to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 22 requests in the queue ahead of you.

@JosefTaylor
Copy link
Contributor Author

Need to fix Ribbed, SlabOnDeck, CorrugatedDeck, and Waffle (and any other non-constant thickness SurfaceProperties) to maintain total depth and material composition.

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 13, 2022

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 13, 2022

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@JosefTaylor
Copy link
Contributor Author

@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 28, 2022

@JosefTaylor to confirm, the following actions are now queued:

  • check null-handling

@JosefTaylor
Copy link
Contributor Author

@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 4, 2022

@JosefTaylor to confirm, the following actions are now queued:

  • check null-handling

michaelhoehn
michaelhoehn approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@michaelhoehn michaelhoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the changes. Works as expected. Please make sure to resolve all comments still outstanding prior to check ready merge.

@JosefTaylor
Copy link
Contributor Author

@pawelbaran can you accept the changes?

@JosefTaylor
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 4, 2022

@JosefTaylor to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 4, 2022

The check null-handling has already been run previously and recorded as a successful check. This check has not been run again at this time.

pawelbaran
pawelbaran approved these changes Aug 5, 2022
View reviewed changes
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the code changes now - glad to have @michaelhoehn to test the functionality as well. The only potential open question is the solid volume, whether it should be area * thickness or area * volume per area. Marking @IsakNaslundBh to hopefully have a look at it and raise concerns if any. Thanks @JosefTaylor well done 👍

@pawelbaran
Copy link
Member

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 5, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance
  • check ready-to-merge

There are 56 requests in the queue ahead of you.

@pawelbaran
Copy link
Member

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 8, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

There are 75 requests in the queue ahead of you.

@pawelbaran
Copy link
Member

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 8, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

There are 85 requests in the queue ahead of you.

@pawelbaran
Copy link
Member

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 8, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

There are 113 requests in the queue ahead of you.

@pawelbaran
Copy link
Member

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 8, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

There are 117 requests in the queue ahead of you.

@JosefTaylor
Copy link
Contributor Author

@pawelbaran thanks for the final check, do you know what's up with BHoMBot?

@pawelbaran
Copy link
Member

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 9, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

There are 18 requests in the queue ahead of you.

@pawelbaran
Copy link
Member

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 9, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

There are 4 requests in the queue ahead of you.

@pawelbaran pawelbaran added the type:feature New capability or enhancement label Aug 9, 2022
@pawelbaran
Copy link
Member

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 9, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

@pawelbaran pawelbaran merged commit 1e50ffb into main Aug 9, 2022
@pawelbaran pawelbaran deleted the Structure_Engine-#2881-add-Wall(Panel)-and-Floor(Panel) branch August 9, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelhoehn michaelhoehn michaelhoehn approved these changes

@pawelbaran pawelbaran pawelbaran approved these changes

@IsakNaslundBh IsakNaslundBh Awaiting requested review from IsakNaslundBh IsakNaslundBh is a code owner

@rwemay rwemay Awaiting requested review from rwemay rwemay is a code owner

@al-fisher al-fisher Awaiting requested review from al-fisher al-fisher is a code owner

@FraserGreenroyd FraserGreenroyd Awaiting requested review from FraserGreenroyd FraserGreenroyd is a code owner

@mchaf mchaf Awaiting requested review from mchaf

@Martian42 Martian42 Awaiting requested review from Martian42

Assignees

@JosefTaylor JosefTaylor

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
5 participants
@JosefTaylor @FraserGreenroyd @pawelbaran @michaelhoehn @BHoMBot