Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Humans_Engine: Fix CValue variable use #2879

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

agneslindblom
Copy link
Contributor

Issues addressed by this PR

Fixes #2878

Test files

Changelog

Additional comments

@agneslindblom agneslindblom added severity:critical No workaround exists. Essential to continue type:bug Error or unexpected behaviour labels Jul 4, 2022
@agneslindblom agneslindblom requested a review from al-fisher as a code owner July 4, 2022 09:35
@agneslindblom agneslindblom self-assigned this Jul 4, 2022
@agneslindblom agneslindblom requested a review from rwemay as a code owner July 4, 2022 09:35
@agneslindblom agneslindblom requested review from IsakNaslundBh and FraserGreenroyd and removed request for rwemay and al-fisher July 4, 2022 09:36
@agneslindblom
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 4, 2022

@agneslindblom to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

@agneslindblom
Copy link
Contributor Author

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 4, 2022

@agneslindblom to confirm, the following checks are now queued:

  • copyright-compliance
  • dataset-compliance

There are 9 requests in the queue ahead of you.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change is logical based on history of changes to this file. Reviewed/tested through with @agneslindblom on their project.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 4, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • versioning

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 4, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • installer

There are 2 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 5, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • versioning
  • ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 10cb9e2 into main Jul 5, 2022
@FraserGreenroyd FraserGreenroyd deleted the Humans_Engine-#2878-FixCValueAnalysis branch July 5, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity:critical No workaround exists. Essential to continue type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Humans_Engine: Correct CValue output
2 participants