Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 5.2 Previous Version Attributes #2875

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

BHoMBot
Copy link
Member

@BHoMBot BHoMBot commented Jun 27, 2022

Remove 5.2 Previous Version Attributes

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 27, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • versioning

There are 118 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 27, 2022

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from a DevOps perspective after code review.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 27, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 951 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 27, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • copyright-compliance

There are 1020 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 27, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • dataset-compliance

There are 1070 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 27, 2022

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 27, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • ready-to-merge

There are 339 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 27, 2022

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is code-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 7073507215

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 7073507215

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 27, 2022

@FraserGreenroyd I have now provided a passing check on reference 7073507215 as requested.

@FraserGreenroyd FraserGreenroyd merged commit bdde555 into main Jun 27, 2022
@FraserGreenroyd FraserGreenroyd deleted the BHoM-RemovePreviousVersion52 branch June 27, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants