-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reflection_Engine: Extract descriptions of enum options #1586
Reflection_Engine: Extract descriptions of enum options #1586
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks fine, but I have a question as to whether we really want to display all values? Some of our enums can be quite large, this might create a massive wall of text on the description? I know that might be an edge case, which is why I'd be happy to approve if you're happy @IsakNaslundBh but figured I'd raise it.
@FraserGreenroyd Thought about that, but thought it never would get tooo bad. But could put a limit of say 10 items, and state something like "...and more" after. Do you have an example of a really long enum, so I can check how it looks? |
@IsakNaslundBh I would support an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine, code LGTM.
/azp run BHoM_Engine.CheckInstaller |
BHoM_Engine.CheckCompliance |
Azure Pipelines successfully started running 1 pipeline(s). |
Issues addressed by this PR
Closes #1584
Adding the options of the enums, and their inner descriptions, to the description text of an enum. Enum values and text below added:
Test files
Changelog
Additional comments