-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialiser_Engine: Fix ToJson() method for when input is null #1222
Serialiser_Engine: Fix ToJson() method for when input is null #1222
Conversation
@BingWangUS, FYI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with empty lists and null
s - all ok.
I think @BingWangUS's point in ' though was to be more explicit with a message on why it is failing?
Hi team, Thanks for responding to this. However, it does not solved the bug for me, when using 2.4 alpha 66 installer, assuming this is included. See the attach screenshot. I did not open Revit so clearly the pull function is giving empty data output. Therefore, the ToJson component is also taking empty inputs. Here is the error message: "1. This component failed to run properly. Are you sure you have the correct type of inputs? The error message is misleading since it says not correct input at the beginning instead of no input. I was expecting a warning message as the second ToJson component says. See the test file here. I understand this is a small issue because the error message also says null values. So feel free to discard this. |
You need to connect type to you filter request ie Environment.Elements.Building |
Thanks Michal. However, my point is, in any case the pull function is not working in this situation and not giving any data out, so the ToJson component should perform the same as the second ToJson, which I don't understand why not. |
Issues addressed by this PR
Closes #1221
Test files
See issue #1221