Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geometry_Engine: Expose tolerances #1170

Merged
merged 2 commits into from
Sep 6, 2019
Merged

Geometry_Engine: Expose tolerances #1170

merged 2 commits into from
Sep 6, 2019

Conversation

FraserGreenroyd
Copy link
Contributor

Issues addressed by this PR

Fixes #1156
Fixes #1157

Test files

N/A

Changelog

  • Expose tolerance parameter on Normal query for Curve inputs
  • Expose tolerance parameter on Centroid query for Curve inputs
  • Deprecate existing Normal and Centroid queries as a result of the above

Additional comments

This exposes tolerances for methods which can utilise tolerances to provide greater control when utilising these geometry methods within code and visual programming.

@FraserGreenroyd FraserGreenroyd self-assigned this Sep 6, 2019
@FraserGreenroyd FraserGreenroyd added the size:S Measured in minutes label Sep 6, 2019
@FraserGreenroyd FraserGreenroyd mentioned this pull request Sep 6, 2019
Closed
michaldengusiak
michaldengusiak approved these changes Sep 6, 2019
View reviewed changes
Copy link
Member

@michaldengusiak michaldengusiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great thanks

@FraserGreenroyd FraserGreenroyd merged commit ca12476 into master Sep 6, 2019
@FraserGreenroyd FraserGreenroyd deleted the Geometry_Engine-#1157-ExposeTolerances branch September 6, 2019 15:21
@pawelbaran
Copy link
Member

I quickly went through the code and not sure I agree with the changes. As far as I can see, after the changes Centroid for some types takes tolerance argument, while for some it does not (incl. the interface method). 🤔

@FraserGreenroyd FraserGreenroyd mentioned this pull request Sep 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldengusiak michaldengusiak michaldengusiak approved these changes

@pawelbaran pawelbaran Awaiting requested review from pawelbaran pawelbaran is a code owner

Assignees

@FraserGreenroyd FraserGreenroyd

Labels
size:S Measured in minutes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Geometry_Engine: Expose tolerance in Query Normal Geometry_Engine: Expose tolerance in Query Centroid
3 participants
@FraserGreenroyd @pawelbaran @michaldengusiak