Planning_Engine : Update Create method to include Description Property #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
al-fisher
added
size:XS
|
@FraserGreenroyd - wonder if this might be one for you to review? - is a small one. |
FraserGreenroyd
approved these changes
Sep 6, 2019
There was a problem hiding this comment.
Fundamentally LGTM, some questions that might be best resolved in future issues:
- Do we want to update the other
Create.Milestonemethod to also accept a description? - Do we want to consolidate the
Create.Milestoneoptions into one to avoid confusion on the UIs? - Do we want to include documentation (
Description,Input,Outputattributes) for the create methods as we have started to do in the other engines?
Accept that Planning_oM/Engine are unlikely to be used by a large group (at least initially) so perhaps confusion on the UIs isn't a consideration here as the only people using it are likely to know what they're looking for.
Sorry - @FraserGreenroyd - responding to your comments above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
BHoM/BHoM#548
Issues addressed by this PR
Closes #1168