Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diffing_Engine : Initial implementation #1150

Merged
merged 11 commits into from
Sep 16, 2019

Conversation

alelom
Copy link
Member

@alelom alelom commented Aug 28, 2019

NOTE: Depends on

BHoM/BHoM#541

This is for a prototype of the Diffing_Engine.

Ported #1103 and adapted to the newly agreed concept as discussed with @al-fisher

Issues addressed by this PR

Test files

Code examples: see #1113 and #1119.
Grasshopper script: https://burohappold.sharepoint.com/:f:/s/BHoM/EtVg-MNP33dHhB_XtRYojXQBXg4OXTMic7c-EQUoY-4ktw?e=XfXyCJ

Changelog

  • First prototype of the Diffing_Engine that performs Collection-level and property-level diffing for objects.

@alelom alelom requested a review from al-fisher August 29, 2019 18:16
@alelom alelom marked this pull request as ready for review August 29, 2019 18:16
@alelom alelom requested review from adecler and rwemay as code owners August 29, 2019 18:16
@alelom
Copy link
Member Author

alelom commented Aug 29, 2019

@al-fisher have a go with the Grasshopper example file above and let me know!

@al-fisher
Copy link
Member

al-fisher commented Aug 29, 2019

Great stuff - thanks @alelom. Will do!

@alelom alelom added the type:feature New capability or enhancement label Aug 30, 2019
@alelom alelom added this to the BHoM 2.4 β MVP milestone Aug 30, 2019
@alelom alelom self-assigned this Aug 30, 2019
@FraserGreenroyd
Copy link
Contributor

Hi @alelom per updated guidelines can you remove BHoM_Engine from the PR title (but keep Diffing_Engine) 😄

@alelom alelom changed the title BHoM_Engine: Diffing_Engine first implementation for next release Diffing_Engine first implementation for next release Sep 3, 2019
@epignatelli
Copy link
Member

According to Sprint Closure call - @al-fisher , @alelom is asking for merging this to solve the milestone. To be taken offline.

@al-fisher al-fisher changed the title Diffing_Engine first implementation for next release Diffing_Engine : Initial implementation Sep 14, 2019
@al-fisher
Copy link
Member

al-fisher commented Sep 14, 2019

FYI added the "Depends on:" to the PR description. Indeed obvious - and the robots 🤖 🤖 found matching PR as branch names correspond - but useful for clarity to ensure referenced! 😄

Copy link
Member

@al-fisher al-fisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff.
@alelom lets raise a few more specific further issues to do smaller sprints now this good prototype is complete

@al-fisher al-fisher merged commit c90166a into master Sep 16, 2019
@al-fisher al-fisher deleted the Diffing_Engine-toBeMergedForAlpha branch September 16, 2019 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diffing_Engine: implement property-level diffing Diffing_Engine: Implement hashing
4 participants