Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure_Engine: Closes #1127 Adds name to create method for RigidLink #1143

Merged
merged 2 commits into from
Sep 12, 2019

Conversation

peterjamesnugent
Copy link
Member

Issues addressed by this PR

Closes #1127

Added name to create method for RigidLink.

Test files

https://burohappold.sharepoint.com/:u:/s/BHoM/ERKv9v45aXFLrnN-Mxw3rNkBwwe62gb2vTk0av7rrQ-7ow?e=BLG7aU

Changelog

Added name to create method for RigidLink.

@peterjamesnugent peterjamesnugent added severity:low Doesn't stop/slow current workflow size:XS Measured in seconds type:feature New capability or enhancement labels Aug 20, 2019
@peterjamesnugent peterjamesnugent self-assigned this Aug 20, 2019
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on formatting:

  • Please deprecate this method
  • Please put the name towards the end of the method and give it default ""

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IsakNaslundBh IsakNaslundBh merged commit 688ac3c into master Sep 12, 2019
@IsakNaslundBh IsakNaslundBh deleted the Issue-1127-NameAddedToRigidLinkCreateMethod branch September 12, 2019 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity:low Doesn't stop/slow current workflow size:XS Measured in seconds type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Structure_Engine: Add name to create methods for RigidLink
2 participants